Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for suppliers #1495

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

aeitzman
Copy link
Contributor

No description provided.

@aeitzman aeitzman requested review from a team as code owners March 13, 2024 18:18
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsirac
Copy link
Contributor

lsirac commented Mar 13, 2024

Might as well add changes to the user guide here too

@aeitzman aeitzman requested a review from a team as a code owner March 14, 2024 16:30
@aeitzman aeitzman merged commit 316d65c into googleapis:programmatic-auth Mar 14, 2024
3 of 5 checks passed
aeitzman added a commit that referenced this pull request Mar 15, 2024
…entials (#1496)

* feat: refactor AWS and identity pool credentials to use suppliers (#1484)

* feat: refactor aws and identity pool credentials to use supplier framework

* Linting

* changing class types

* linting

* remove unused import

* Fix typing

* add docstring and fix casing

* feat: Adds support for custom suppliers in AWS and Identity Pool credential instantiation (#1494)

* feat: refactor aws and identity pool credentials to use supplier framework

* Linting

* changing class types

* linting

* remove unused import

* Fix typing

* add docstring and fix casing

* feat: adds support for passing suppliers to credentials.

* fixes merge issues and adds _has_custom_supplier method

* adds _has_custom_supplier function to identity_pool

* Update google/auth/external_account.py

Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>

* Respond to comments and fix docs

---------

Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>

* docs: add documentation for suppliers (#1495)

* docs: update docs for programmatic

* add space

* update user guide

* update docs

* Apply suggestions from code review

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update docs

* Add docs about context and request

---------

Co-authored-by: Carl Lundin <108372512+clundin25@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants