Signer and IDTokenCredentials implementation using default service account on GCE #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryzthov
force-pushed
the
gce-id-token
branch
4 times, most recently
from
2101e9f
to
21a9f5b
Compare
- Add Signer and IDTokenCredentials implementation Signed-off-by: Christophe Taton <christophe.taton@gmail.com>
|
@theacodes Could you take a look at this? I haven't added any test yet, but I'd like some feedback before spending more time on this. |
|
Hi @kryzthov - just a heads up that I'm currently OOO until next week but I'll take a quick lookl |
|
All good! No rush, it's been there for a while, and it's not blocking! Enjoy your time off! |
theacodes
suggested changes
May 16, 2018
| @@ -108,3 +117,163 @@ def service_account_email(self): | |||
| def requires_scopes(self): | |||
| """False: Compute Engine credentials can not be scoped.""" | |||
| return False | |||
|
|
|||
|
|
|||
| class Signer(crypt.Signer): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| class IDTokenCredentials(credentials.Credentials, credentials.Signing): | ||
| """Open ID Connect ID Token-based service account credentials. | ||
|
|
||
| These credentials relies on the default service account of a GCE instance. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Reuse google.auth.iam.Signer - Expose `request` and `service_account_email`.
|
Anymore feedback on this? |
theacodes
reviewed
May 24, 2018
|
|
||
| self._signer = iam.Signer( | ||
| request=request, | ||
| credentials=Credentials(), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
suggested changes
May 24, 2018
kryzthov
force-pushed
the
gce-id-token
branch
4 times, most recently
from
91da8fe
to
cb74258
Compare
Signed-off-by: Christophe Taton <christophe.taton@gmail.com>
theacodes
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes: