Add downscoping to ouath2 credentials #309

eugenewf · 2018-11-27T01:23:40Z

No description provided.

googlebot · 2018-11-27T01:23:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

eugenewf · 2018-11-27T01:39:37Z

fixed cla (theoretically)

googlebot · 2018-11-27T01:39:43Z

CLAs look good, thanks!

docs/reference/google.auth.app_engine.rst

-google.auth.app_engine module
-=============================
+google.auth.app\_engine module
+==============================


docs/reference/google.auth.compute_engine.credentials.rst

docs/reference/google.auth.compute_engine.rst

docs/reference/google.auth.crypt.rst

-google.auth.crypt module
-========================
+google.auth.crypt package
+=========================


docs/reference/google.auth.environment_vars.rst

docs/reference/google.oauth2.id_token.rst

docs/reference/google.oauth2.service_account.rst

google/oauth2/credentials.py

+            downscope (bool): Whether to reduce the requested scopes from those
+                of the refresh token to those listed in scopes. Useful if
+                refresh token has a wild card scope (e.g.
+                'https://www.googleapis.com/auth/any-api').


tseaver · 2018-11-27T17:53:56Z

@eugenewf Note that the tests are passing on CI, so you don't have any work to do to get Python 3.4 working.

eugenewf · 2018-11-29T23:53:51Z

@theacodes Are there any further actions you'd like me to take here? (e.g. with regards to #309 (comment) or #309 (comment))

theacodes · 2018-12-03T17:57:40Z

Not at the moment. I just need to find time to review.

…

On Thu, Nov 29, 2018 at 3:53 PM Eugene W. Foley ***@***.***> wrote: @theacodes <https://github.com/theacodes> Are there any further actions you'd like me to take here? (e.g. with regards to #309 (comment) <#309 (comment)> or #309 (comment) <#309 (comment)> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#309 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc_iBT_bMaY42BVSQQY86X-4YkrB9ks5u0HOQgaJpZM4Y0V31> .

google/oauth2/credentials.py

@@ -71,6 +71,10 @@ def __init__(self, token, refresh_token=None, id_token=None,
                to obtain authorization. This is a purely informative parameter
                that can be used by :meth:`has_scopes`. OAuth 2.0 credentials
                can not request additional scopes after authorization.
+            downscope (bool): Whether to reduce the requested scopes from those


…brary-python Syncing with changes made over the holidays.

…n via classmethods from_authorized_user_info() and from_authorized_user_file()

eugenewf · 2019-05-09T19:50:20Z

Apologies for dropping this for so long, I've been rather ill.

I had a conversation with Thea back in February resulting in a recommendation to always explicitly request the scopes if they have been provided. I've written that up and added a failure message for the case where the server only grants some of the scopes requested (which is allowed by the oauth spec). Comments appreciated if anyone thinks there's a better way to handle that case :)

eugenewf and others added 8 commits November 26, 2018 16:29

Update credentials.py

8715c84

Update _client.py

f01d9ae

Update test_credentials.py

0766130

Update test__client.py

1e04ce3

Update credentials.py

9205cc8

Update credentials.py

296e615

Update _client.py

dbaa8cb

doc update

dad9326

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 27, 2018

eugenewf closed this Nov 27, 2018

eugenewf reopened this Nov 27, 2018

eugenewf closed this Nov 27, 2018

eugenewf reopened this Nov 27, 2018

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 27, 2018

tseaver suggested changes Nov 27, 2018

View reviewed changes

eugenewf added 2 commits November 27, 2018 13:12

Remove backslashes added by tox doc tools.

c89bbe4

Remove = added by tox doc tools.

f13636b

tseaver approved these changes Nov 27, 2018

View reviewed changes

theacodes reviewed Dec 14, 2018

View reviewed changes

eugenewf added 4 commits January 31, 2019 16:51

Merge branch 'master' of https://github.com/googleapis/google-auth-li…

e6a8dd0

…brary-python Syncing with changes made over the holidays.

Create downscoped credentials via bound method downscope() rather tha…

d743986

…n via classmethods from_authorized_user_info() and from_authorized_user_file()

remove \ added by tox -e docgen

e561c28

remove = added by tox -e docgen

d27df98

JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019

yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019

eugenewf added 2 commits May 8, 2019 16:18

Merge https://github.com/googleapis/google-auth-library-python

92f8b44

Credentials always request explicit scopes, if provided.

2845de8

theacodes approved these changes May 22, 2019

View reviewed changes

theacodes merged commit 49a18c4 into googleapis:master May 22, 2019

yoshi-automation removed the 🚨 This issue needs some love. label Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add downscoping to ouath2 credentials #309

Add downscoping to ouath2 credentials #309

eugenewf commented Nov 27, 2018

googlebot commented Nov 27, 2018

eugenewf commented Nov 27, 2018

googlebot commented Nov 27, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 27, 2018

eugenewf commented Nov 29, 2018

theacodes commented Dec 3, 2018 via email

This comment was marked as spam.

This comment was marked as spam.

eugenewf commented May 9, 2019

Add downscoping to ouath2 credentials #309

Add downscoping to ouath2 credentials #309

Conversation

eugenewf commented Nov 27, 2018

googlebot commented Nov 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

eugenewf commented Nov 27, 2018

googlebot commented Nov 27, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 27, 2018

eugenewf commented Nov 29, 2018

theacodes commented Dec 3, 2018 via email

This comment was marked as spam.

This comment was marked as spam.

eugenewf commented May 9, 2019