Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show the transport exception that happened for GCE Metadata #474

Merged
merged 4 commits into from
Jul 21, 2020
Merged

feat: Show the transport exception that happened for GCE Metadata #474

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70bedf6
feat: Show the transport exception that happened when accessing the C…
hilts-vaughan Mar 26, 2020
47b32fa
fix: blacken to appease lint
tseaver Jul 21, 2020
7902923
Merge branch 'master' into mst/log-compute-engine-response
tseaver Jul 21, 2020
139baae
Merge branch 'master' into mst/log-compute-engine-response
gcf-merge-on-green[bot] Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions google/auth/compute_engine/_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,13 @@ def ping(request, timeout=_METADATA_DEFAULT_TIMEOUT, retry_count=3):
and metadata_flavor == _METADATA_FLAVOR_VALUE
)

except exceptions.TransportError:
_LOGGER.info(
"Compute Engine Metadata server unavailable on" "attempt %s of %s",
except exceptions.TransportError as e:
_LOGGER.warning(
"Compute Engine Metadata server unavailable on"
"attempt %s of %s. Reason: %s",
retries + 1,
retry_count,
e,
)
retries += 1

Expand Down Expand Up @@ -144,11 +146,13 @@ def get(request, path, root=_METADATA_ROOT, recursive=False, retry_count=5):
response = request(url=url, method="GET", headers=_METADATA_HEADERS)
break

except exceptions.TransportError:
_LOGGER.info(
"Compute Engine Metadata server unavailable on" "attempt %s of %s",
except exceptions.TransportError as e:
_LOGGER.warning(
"Compute Engine Metadata server unavailable on"
"attempt %s of %s. Reason: %s",
retries + 1,
retry_count,
e,
)
retries += 1
else:
Expand Down