Add compute engine system tests #54

theacodes · 2016-10-25T20:34:26Z

Resolves #40

google/auth/compute_engine/credentials.py

@@ -71,7 +70,7 @@ def _retrieve_info(self, request):
            service_account=self._service_account_email)

        self._service_account_email = info['email']
-        self._scopes = _helpers.string_to_scopes(info['scopes'])
+        self._scopes = info['scopes']


system_tests/test_compute_engine.py

+from google.auth import _helpers
+from google.auth import compute_engine
+from google.auth.compute_engine import _metadata
+import pytest


system_tests/test_compute_engine.py

+    if not _metadata.ping(request):
+        pytest.skip('Compute Engine metadata service is not available.')
+
+


system_tests/test_compute_engine.py

+        pytest.skip('Compute Engine metadata service is not available.')
+
+
+def test_refresh(request, token_info):


system_tests/test_compute_engine.py

+    credentials.refresh(request)
+
+    assert credentials.token is not None
+    assert credentials._service_account_email is not None


system_tests/test_compute_engine.py

+    assert credentials._service_account_email is not None
+
+    info = token_info(credentials.token)
+    info_scopes = _helpers.string_to_scopes(info['scope'])


system_tests/test_service_account.py

-    assert info['scope'] == (
-        'https://www.googleapis.com/auth/userinfo.email '
-        'https://www.googleapis.com/auth/userinfo.profile')
+    info_scopes = _helpers.string_to_scopes(info['scope'])


dhermes · 2016-10-25T21:12:03Z

LGTM (in light of the existence of #55).

Also, don't block here, but as a general rule I try to have system tests only rely on public attributes. Why isn't it valuable for the svc. acct. email to be public?

theacodes · 2016-10-25T21:20:43Z

Why isn't it valuable for the svc. acct. email to be public?

It could be useful, but I want to err on the side of being limited in our public interface.

Add compute engine system tests

a7ebcfd

theacodes added this to the 1.0.0 milestone Oct 25, 2016

theacodes assigned dhermes Oct 25, 2016

dhermes reviewed Oct 25, 2016

View reviewed changes

Address review comments

ee44004

dhermes mentioned this pull request Oct 25, 2016

Add system tests for ADC #55

Closed

theacodes merged commit f7b9279 into master Oct 25, 2016

theacodes deleted the compute-engine-system-tests branch October 25, 2016 21:20

theacodes unassigned dhermes Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compute engine system tests #54

Add compute engine system tests #54

theacodes commented Oct 25, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 25, 2016

theacodes commented Oct 25, 2016

		if not _metadata.ping(request):
		pytest.skip('Compute Engine metadata service is not available.')

		pytest.skip('Compute Engine metadata service is not available.')


		def test_refresh(request, token_info):

Add compute engine system tests #54

Add compute engine system tests #54

Conversation

theacodes commented Oct 25, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Oct 25, 2016

theacodes commented Oct 25, 2016