Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(packaging): add support for Python 3.8 #569

Merged
merged 2 commits into from Jul 23, 2020
Merged

feat(packaging): add support for Python 3.8 #569

merged 2 commits into from Jul 23, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 21, 2020 •
edited

Release-As: 1.20.0

Closes #568

@tseaver tseaver requested a review from busunkim96 July 21, 2020 21:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2020
busunkim96
busunkim96 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You don't need to add the 'Release-As' since this is already labeled as a feat. Once this is meregd #567 will be updated by the bot

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1aad54a into googleapis:master Jul 23, 2020
@tseaver tseaver deleted the 568-add-python-3.8-support branch July 30, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.8
2 participants
@tseaver @busunkim96