-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: all asynchronous credential types required for all authentication types (service accounts, default... etc) #573
Merged
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ef6d872
feat: asyncio http request logic and asynchronous credentials log c
anibadde 0a63b3c
feat: all asynchronous credentials types implemented and with tests
anibadde 06606ff
feat: added the private scope for Response class
anibadde cd57fad
feat: added docstring for Auth Session request method
anibadde a38e333
fix: Changed initialization of client session to within an async cont…
anibadde 57d6d10
changed aiohttp_requests abbreviation for the async authorized sessio…
anibadde 1db84f2
Merge branch 'auth1' into auth2
anibadde cc14082
fix: changed abbrevation of the aiohttp_requests file
anibadde aa6ece2
fix: comments on PR regarding shared data between requests and aiohtt…
anibadde d88839b
fix: fixed noxfile test dependency sharing
anibadde dfc6251
fix: Made fixes based on comments on first PR
anibadde c62dd1a
fix: fixed the noxfile dependencies between sync and async unit tests
anibadde 7080d14
fix: cover async dependency
anibadde 8122dbb
Merge branch 'auth1' into auth2
anibadde 77ca4c7
Merge branch 'async' into auth2
anibadde b4c306f
fix: merge conflict issue with credentials
anibadde 9ddb911
fix: merge conflict #2
anibadde 8f2d0ef
fix: changed duplicated constants for sync-->async inheritance relati…
anibadde 9ec8277
fix: async docstring
anibadde 8f254de
refactoring
anibadde aa04dc9
fix: refactoring
anibadde 0c4c3b6
fix: first round of comments, refactoring and test duplication changes
anibadde 92175f2
fix: removed duplication in _default_async
anibadde 77d7b6e
fix: removed oauth2 client
anibadde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,307 @@ | ||
# Copyright 2020 Google Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Application default credentials. | ||
|
||
Implements application default credentials and project ID detection. | ||
""" | ||
|
||
import io | ||
import json | ||
import os | ||
import warnings | ||
|
||
import six | ||
|
||
from google.auth import _default as default | ||
from google.auth import environment_vars | ||
from google.auth import exceptions | ||
import google.auth.transport._http_client | ||
|
||
|
||
def _warn_about_problematic_credentials(credentials): | ||
"""Determines if the credentials are problematic. | ||
|
||
Credentials from the Cloud SDK that are associated with Cloud SDK's project | ||
are problematic because they may not have APIs enabled and have limited | ||
quota. If this is the case, warn about it. | ||
""" | ||
from google.auth import _cloud_sdk | ||
|
||
if credentials.client_id == _cloud_sdk.CLOUD_SDK_CLIENT_ID: | ||
warnings.warn(default._CLOUD_SDK_CREDENTIALS_WARNING) | ||
|
||
|
||
def load_credentials_from_file(filename, scopes=None, quota_project_id=None): | ||
"""Loads Google credentials from a file. | ||
|
||
The credentials file must be a service account key or stored authorized | ||
user credentials. | ||
|
||
Args: | ||
filename (str): The full path to the credentials file. | ||
scopes (Optional[Sequence[str]]): The list of scopes for the credentials. If | ||
specified, the credentials will automatically be scoped if | ||
necessary | ||
quota_project_id (Optional[str]): The project ID used for | ||
quota and billing. | ||
|
||
Returns: | ||
Tuple[google.auth.credentials.Credentials, Optional[str]]: Loaded | ||
credentials and the project ID. Authorized user credentials do not | ||
have the project ID information. | ||
|
||
Raises: | ||
google.auth.exceptions.DefaultCredentialsError: if the file is in the | ||
wrong format or is missing. | ||
""" | ||
if not os.path.exists(filename): | ||
raise exceptions.DefaultCredentialsError( | ||
"File {} was not found.".format(filename) | ||
) | ||
|
||
with io.open(filename, "r") as file_obj: | ||
try: | ||
info = json.load(file_obj) | ||
except ValueError as caught_exc: | ||
new_exc = exceptions.DefaultCredentialsError( | ||
"File {} is not a valid json file.".format(filename), caught_exc | ||
) | ||
six.raise_from(new_exc, caught_exc) | ||
|
||
# The type key should indicate that the file is either a service account | ||
# credentials file or an authorized user credentials file. | ||
credential_type = info.get("type") | ||
|
||
if credential_type == default._AUTHORIZED_USER_TYPE: | ||
from google.oauth2 import credentials_async as credentials | ||
|
||
try: | ||
credentials = credentials.Credentials.from_authorized_user_info( | ||
info, scopes=scopes | ||
).with_quota_project(quota_project_id) | ||
except ValueError as caught_exc: | ||
msg = "Failed to load authorized user credentials from {}".format(filename) | ||
new_exc = exceptions.DefaultCredentialsError(msg, caught_exc) | ||
six.raise_from(new_exc, caught_exc) | ||
if not credentials.quota_project_id: | ||
_warn_about_problematic_credentials(credentials) | ||
return credentials, None | ||
|
||
elif credential_type == default._SERVICE_ACCOUNT_TYPE: | ||
from google.oauth2 import service_account_async as service_account | ||
|
||
try: | ||
credentials = service_account.Credentials.from_service_account_info( | ||
info, scopes=scopes | ||
).with_quota_project(quota_project_id) | ||
except ValueError as caught_exc: | ||
msg = "Failed to load service account credentials from {}".format(filename) | ||
new_exc = exceptions.DefaultCredentialsError(msg, caught_exc) | ||
six.raise_from(new_exc, caught_exc) | ||
return credentials, info.get("project_id") | ||
|
||
else: | ||
raise exceptions.DefaultCredentialsError( | ||
"The file {file} does not have a valid type. " | ||
"Type is {type}, expected one of {valid_types}.".format( | ||
file=filename, type=credential_type, valid_types=default._VALID_TYPES | ||
) | ||
) | ||
|
||
|
||
def _get_gcloud_sdk_credentials(): | ||
"""Gets the credentials and project ID from the Cloud SDK.""" | ||
from google.auth import _cloud_sdk | ||
|
||
# Check if application default credentials exist. | ||
credentials_filename = _cloud_sdk.get_application_default_credentials_path() | ||
|
||
if not os.path.isfile(credentials_filename): | ||
return None, None | ||
|
||
credentials, project_id = load_credentials_from_file(credentials_filename) | ||
|
||
if not project_id: | ||
project_id = _cloud_sdk.get_project_id() | ||
|
||
return credentials, project_id | ||
|
||
|
||
def _get_explicit_environ_credentials(): | ||
"""Gets credentials from the GOOGLE_APPLICATION_CREDENTIALS environment | ||
variable.""" | ||
explicit_file = os.environ.get(environment_vars.CREDENTIALS) | ||
|
||
if explicit_file is not None: | ||
credentials, project_id = load_credentials_from_file( | ||
os.environ[environment_vars.CREDENTIALS] | ||
) | ||
|
||
return credentials, project_id | ||
|
||
else: | ||
return None, None | ||
|
||
|
||
def _get_gae_credentials(): | ||
"""Gets Google App Engine App Identity credentials and project ID.""" | ||
# While this library is normally bundled with app_engine, there are | ||
# some cases where it's not available, so we tolerate ImportError. | ||
try: | ||
import google.auth.app_engine as app_engine | ||
except ImportError: | ||
return None, None | ||
|
||
try: | ||
credentials = app_engine.Credentials() | ||
project_id = app_engine.get_project_id() | ||
return credentials, project_id | ||
except EnvironmentError: | ||
return None, None | ||
|
||
|
||
def _get_gce_credentials(request=None): | ||
crwilcox marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""Gets credentials and project ID from the GCE Metadata Service.""" | ||
# Ping requires a transport, but we want application default credentials | ||
# to require no arguments. So, we'll use the _http_client transport which | ||
# uses http.client. This is only acceptable because the metadata server | ||
# doesn't do SSL and never requires proxies. | ||
|
||
# While this library is normally bundled with compute_engine, there are | ||
# some cases where it's not available, so we tolerate ImportError. | ||
try: | ||
from google.auth import compute_engine | ||
from google.auth.compute_engine import _metadata | ||
except ImportError: | ||
return None, None | ||
|
||
if request is None: | ||
request = google.auth.transport._http_client.Request() | ||
|
||
if _metadata.ping(request=request): | ||
# Get the project ID. | ||
try: | ||
project_id = _metadata.get_project_id(request=request) | ||
except exceptions.TransportError: | ||
project_id = None | ||
|
||
return compute_engine.Credentials(), project_id | ||
else: | ||
return None, None | ||
|
||
|
||
def default_async(scopes=None, request=None, quota_project_id=None): | ||
"""Gets the default credentials for the current environment. | ||
|
||
`Application Default Credentials`_ provides an easy way to obtain | ||
credentials to call Google APIs for server-to-server or local applications. | ||
This function acquires credentials from the environment in the following | ||
order: | ||
|
||
1. If the environment variable ``GOOGLE_APPLICATION_CREDENTIALS`` is set | ||
to the path of a valid service account JSON private key file, then it is | ||
loaded and returned. The project ID returned is the project ID defined | ||
in the service account file if available (some older files do not | ||
contain project ID information). | ||
2. If the `Google Cloud SDK`_ is installed and has application default | ||
credentials set they are loaded and returned. | ||
|
||
To enable application default credentials with the Cloud SDK run:: | ||
|
||
gcloud auth application-default login | ||
|
||
If the Cloud SDK has an active project, the project ID is returned. The | ||
active project can be set using:: | ||
|
||
gcloud config set project | ||
|
||
3. If the application is running in the `App Engine standard environment`_ | ||
then the credentials and project ID from the `App Identity Service`_ | ||
are used. | ||
4. If the application is running in `Compute Engine`_ or the | ||
`App Engine flexible environment`_ then the credentials and project ID | ||
are obtained from the `Metadata Service`_. | ||
5. If no credentials are found, | ||
:class:`~google.auth.exceptions.DefaultCredentialsError` will be raised. | ||
|
||
.. _Application Default Credentials: https://developers.google.com\ | ||
/identity/protocols/application-default-credentials | ||
.. _Google Cloud SDK: https://cloud.google.com/sdk | ||
.. _App Engine standard environment: https://cloud.google.com/appengine | ||
.. _App Identity Service: https://cloud.google.com/appengine/docs/python\ | ||
/appidentity/ | ||
.. _Compute Engine: https://cloud.google.com/compute | ||
.. _App Engine flexible environment: https://cloud.google.com\ | ||
/appengine/flexible | ||
.. _Metadata Service: https://cloud.google.com/compute/docs\ | ||
/storing-retrieving-metadata | ||
|
||
Example:: | ||
|
||
import google.auth | ||
|
||
credentials, project_id = google.auth.default() | ||
|
||
Args: | ||
scopes (Sequence[str]): The list of scopes for the credentials. If | ||
specified, the credentials will automatically be scoped if | ||
necessary. | ||
request (google.auth.transport.Request): An object used to make | ||
HTTP requests. This is used to detect whether the application | ||
is running on Compute Engine. If not specified, then it will | ||
use the standard library http client to make requests. | ||
quota_project_id (Optional[str]): The project ID used for | ||
quota and billing. | ||
Returns: | ||
Tuple[~google.auth.credentials.Credentials, Optional[str]]: | ||
the current environment's credentials and project ID. Project ID | ||
may be None, which indicates that the Project ID could not be | ||
ascertained from the environment. | ||
|
||
Raises: | ||
~google.auth.exceptions.DefaultCredentialsError: | ||
If no credentials were found, or if the credentials found were | ||
invalid. | ||
""" | ||
from google.auth.credentials_async import with_scopes_if_required | ||
|
||
explicit_project_id = os.environ.get( | ||
environment_vars.PROJECT, os.environ.get(environment_vars.LEGACY_PROJECT) | ||
) | ||
|
||
checkers = ( | ||
_get_explicit_environ_credentials, | ||
_get_gcloud_sdk_credentials, | ||
_get_gae_credentials, | ||
lambda: _get_gce_credentials(request), | ||
) | ||
|
||
for checker in checkers: | ||
credentials, project_id = checker() | ||
if credentials is not None: | ||
credentials = with_scopes_if_required( | ||
credentials, scopes | ||
).with_quota_project(quota_project_id) | ||
effective_project_id = explicit_project_id or project_id | ||
if not effective_project_id: | ||
default._LOGGER.warning( | ||
"No project ID could be determined. Consider running " | ||
"`gcloud config set project` or setting the %s " | ||
"environment variable", | ||
environment_vars.PROJECT, | ||
) | ||
return credentials, effective_project_id | ||
|
||
raise exceptions.DefaultCredentialsError(default._HELP_MESSAGE) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract to a helper to share?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to extract from auth/_default