test: Add integration tests for downscoping #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests creates a temporary bucket and 2 objects in it. A downscoped token is then created to access only one of the objects (readonly). The test would then check: - Read access to accessible object is successful. - Write access to that object is unsuccessful. - Read access to the inaccessible object is not successful.
bojeil-google
requested review from
arithmetic1728,
silvolu and
a team
as code owners
google-cla
bot
added
the
cla: yes
tseaver
added
the
do not merge
|
@bojeil-google Unfortunately, your PR has landed in a pocket where the system tests are not being run on Kokoro. @dandhlee is working to correct that issue (see #836). Please hold off merging here until |
|
@tseaver The system test does run, but it just doesn't show up on the dashboard here. I can see on the log that both the |
dandhlee
removed
the
do not merge
arithmetic1728
approved these changes
Aug 16, 2021
tseaver
suggested changes
Aug 16, 2021
|
@bojeil-google please take a look at @tseaver 's comments |
|
All comments were addressed in #838 |
tseaver
added a commit
that referenced
this pull request
Aug 16, 2021
Addresses all comments from: #837 Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests creates a temporary bucket and 2 objects in it.
A downscoped token is then created to access only one of the objects (readonly).
The test would then check: