Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Credentials.default #127

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Fix Credentials.default #127

merged 2 commits into from
Nov 10, 2017

Commits on Nov 10, 2017

  1. Add focus config to RSpec 

    This allows us to focus on specs by changing it to fit.
    @blowmage
    blowmage committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    4c4e6ce View commit details
    Browse the repository at this point in the history

  2. Fix Credentials.default bug 

    If no PATH_ENV_VARS were found Credentials.default would return an empty array.
Update each default lookup method to return nil if no match was found.
Fix call to from_default_paths method, was calling from_default_vars instead.
Add spec coverage for path, json, and default cases.
Add spec coverage for application_default case.
Fix spec coverage to check the return type from calling Credentials.default.
    @blowmage
    blowmage committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    9f395a2 View commit details
    Browse the repository at this point in the history