Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding identity pool credentials #433

Merged
merged 29 commits into from
Jun 20, 2023

Conversation

BigTailWolf
Copy link
Contributor

Add a new type of external account Google::Auth::ExternalAccount::IdentityPoolCredentials which reads the config of workforce/workload identity pool.
This type of credentials retrieve OIDC token (subject token) to exchange with STS (access_token).

@BigTailWolf BigTailWolf requested a review from a team as a code owner May 12, 2023 20:39
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a few nit comments

@BigTailWolf BigTailWolf requested a review from dazuma June 15, 2023 21:47
@BigTailWolf BigTailWolf requested a review from dazuma June 15, 2023 23:00
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BigTailWolf and others added 4 commits June 19, 2023 14:23
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
@bajajneha27 bajajneha27 merged commit 9b78153 into googleapis:main Jun 20, 2023
12 checks passed
@BigTailWolf BigTailWolf deleted the b275366903 branch June 20, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants