This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
feat!: replaces PartitionOptions proto with struct #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 93.66% 93.68% +0.01%
==========================================
Files 158 161 +3
Lines 11215 11241 +26
==========================================
+ Hits 10505 10531 +26
Misses 710 710
Continue to review full report at Codecov.
|
|
taking it mostly on faith this is the same as the other PR and not a trojan :) |
mr-salty
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, all discussions resolved (waiting on @mr-salty)
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…-cloud-cpp-spanner#1035) Fixes googleapis/google-cloud-cpp-spanner#452 Now that PartitionOptions is a struct, it should likely be passed by const-ref and not moved. Well, clang-tidy yells at me otherwise. This is googleapis/google-cloud-cpp-spanner#1030 take two, because I accidentally closed that PR instead of merging it. Why didn't I just reopen that PR? Because I pushed the branch again after and now it won't let me reopen that PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
Now that PartitionOptions is a struct, it should likely be passed by const-ref and not moved. Well, clang-tidy yells at me otherwise.
This is #1030 take two, because I accidentally closed that PR instead of merging it. Why didn't I just reopen that PR? Because I pushed the branch again after and now it won't let me reopen that PR.
This change is