This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
feat!: remove Timestamp::Min() and Timestamp::Max() #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a question as to whether `Timestamp::Min()` and `Timestamp::Max()` should reflect the actual range of `class Timestamp` or the documented range of a Spanner TIMESTAMP field. So, until there is a demonstrated need one way or the other, let's simply remove them.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
==========================================
- Coverage 95.66% 95.63% -0.04%
==========================================
Files 175 175
Lines 13567 13564 -3
==========================================
- Hits 12979 12972 -7
- Misses 588 592 +4
Continue to review full report at Codecov.
|
devjgm
approved these changes
Jan 10, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…e-cloud-cpp-spanner#1182) There is a question as to whether `Timestamp::Min()` and `Timestamp::Max()` should reflect the actual range of `class Timestamp` or the documented range of a Spanner TIMESTAMP field. So, until there is a demonstrated need one way or the other, let's simply remove them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a question as to whether
Timestamp::Min()andTimestamp::Max()should reflect the actual range ofclass Timestampor the documented range of a SpannerTIMESTAMP field. So, until there is a demonstrated need
one way or the other, let's simply remove them.
This change is