This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: only check for per-thread rusage in the benchmark that requires it #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
The `single_row_throughput_benchmark` doesn't use `getrusage()`, so checking for it in `Config` unnecessarily precludes it from running (i.e. when using `bazel` builds). Instead, check in `multiple_rows_cpu_benchmark` which actually does care.
mr-salty
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
+ Coverage 95.63% 95.64% +<.01%
==========================================
Files 174 175 +1
Lines 13567 13570 +3
==========================================
+ Hits 12975 12979 +4
+ Misses 592 591 -1
Continue to review full report at Codecov.
|
coryan
approved these changes
Jan 10, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…it (googleapis/google-cloud-cpp-spanner#1186) * fix: only check for per-thread rusage in the benchmark that requires it The `single_row_throughput_benchmark` doesn't use `getrusage()`, so checking for it in `Config` unnecessarily precludes it from running (i.e. when using `bazel` builds). Instead, check in `multiple_rows_cpu_benchmark` which actually does care. * oops, forgot to update the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
single_row_throughput_benchmarkdoesn't usegetrusage(), sochecking for it in
Configunnecessarily precludes it from running(i.e. when using
bazelbuilds).Instead, check in
multiple_rows_cpu_benchmarkwhich actually does care.This change is