-
Notifications
You must be signed in to change notification settings - Fork 14
feat: use 1 client with multiple channels for the benchmark #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good, assuming I understand the plan: after this you will change the other benchmarks and then rename the *_clients
variables?
Somewhat unrelated: can you attach your results to one of the bugs so we know (in the future) why keeping a single client was enough?
Reviewed 3 of 3 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devbww)
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 95.7% 95.62% -0.09%
==========================================
Files 174 174
Lines 13601 13565 -36
==========================================
- Hits 13017 12971 -46
- Misses 584 594 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'm planning to do the multiple row benchmark in a different PR then make those channels
.
I added a graph to https://github.com/googleapis/google-cloud-cpp-spanner/issues/1193
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devbww)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devbww)
…is/google-cloud-cpp-spanner#1194) * feat: use 1 client with multiple channels for the benchmark Part of googleapis/google-cloud-cpp-spanner#1193
InsertOrUpdateExperiment
useDefaultPRNG
like the othersUpdateDmlExperiment::RunIteration
minimum/maximum_clients
to_channels
Part of #1193
This change is