Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

doc: add skeletons for *_with_timestamp_column #1220

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Jan 29, 2020

This should unblock our doc writer.

Part of #1217, #1218, #1219


This change is Reviewable

@devjgm devjgm requested a review from coryan January 29, 2020 20:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1220 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1220      +/-   ##
=========================================
+ Coverage   95.27%   95.3%   +0.02%     
=========================================
  Files         183     182       -1     
  Lines       13694   13704      +10     
=========================================
+ Hits        13047   13060      +13     
+ Misses        647     644       -3
Impacted Files Coverage Δ
google/cloud/spanner/samples/samples.cc 86.31% <100%> (-0.14%) ⬇️
google/cloud/spanner/internal/retry_loop.h 95.45% <0%> (-4.55%) ⬇️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (ø) ⬆️
google/cloud/spanner/database_admin_connection.h
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (ø) ⬆️
google/cloud/spanner/client.cc 97.41% <0%> (+0.86%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 83.33% <0%> (+1.75%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a439b02...51d322b. Read the comment docs.

@devjgm devjgm merged commit 762021b into googleapis:master Jan 29, 2020
@devjgm devjgm deleted the doc-insert-timestamp branch January 29, 2020 21:57
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants