Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: add CommitTimestamp support #1225

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Jan 30, 2020

Part of #1217, #1218, #1219


This change is Reviewable

@devjgm devjgm requested a review from coryan January 30, 2020 16:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the builds pass, this :lgtm: Thanks!

Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1225 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   94.84%   94.84%   +<.01%     
==========================================
  Files         185      185              
  Lines       13766    13812      +46     
==========================================
+ Hits        13056    13100      +44     
- Misses        710      712       +2
Impacted Files Coverage Δ
google/cloud/spanner/value.cc 97.46% <100%> (+0.2%) ⬆️
google/cloud/spanner/value_test.cc 99.13% <100%> (+0.04%) ⬆️
google/cloud/spanner/value.h 92.8% <100%> (+0.1%) ⬆️
google/cloud/spanner/timestamp.h 100% <100%> (ø) ⬆️
...loud/spanner/internal/partial_result_set_resume.cc 90.9% <0%> (-4.55%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.71% <0%> (-2.07%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (-0.02%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
google/cloud/spanner/internal/transaction_impl.h 100% <0%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bab4c...45626de. Read the comment docs.

@devjgm devjgm merged commit 56effe6 into googleapis:master Jan 30, 2020
@devjgm devjgm deleted the commit-timestamp branch January 30, 2020 17:21
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…r#1225)

* feat: add CommitTimestamp support

* few updates from carlos

* @note line wrapping
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants