Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

docs: add summary of result classes #1243

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Feb 5, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@scotthart
Copy link
Member Author

fixes #1201
fixes #1202

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #1243 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.01%     
==========================================
  Files         185      185              
  Lines       13823    13824       +1     
==========================================
  Hits        13121    13121              
- Misses        702      703       +1
Impacted Files Coverage Δ
google/cloud/spanner/results.h 91.66% <ø> (ø) ⬆️
...loud/spanner/internal/partial_result_set_resume.cc 90.9% <0%> (-4.55%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 68.47% <0%> (-2.18%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
...loud/spanner/internal/partial_result_set_source.cc 93.24% <0%> (-1.36%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-0.16%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (-0.01%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (ø) ⬆️
google/cloud/spanner/transaction.h 100% <0%> (ø) ⬆️
google/cloud/spanner/value.h 92.9% <0%> (+0.1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dcf1dc...dacf4bc. Read the comment docs.

Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devjgm)

@scotthart scotthart merged commit 8c1ef9d into googleapis:master Feb 5, 2020
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants