This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
refactor!: expand SqlParams members into PartitionQueryParams #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
- Coverage 94.84% 94.82% -0.03%
==========================================
Files 184 184
Lines 13805 13806 +1
==========================================
- Hits 13094 13091 -3
- Misses 711 715 +4
Continue to review full report at Codecov.
|
PartitionQueryParams corresponds to PartitionQueryRequest (https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L672), and SqlParams corresponds to ExecuteSqlRequest (https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L439). The former does not "include" the latter, so there may be options or fields in SqlParams that don't belong in PartitionQueryParams. Therefore, we should break this relationship now, while we can.
devjgm
force-pushed
the
split-sql-partition
branch
from
0bb9234
to
daa742b
Compare
coryan
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scotthart)
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…apis/google-cloud-cpp-spanner#1263) PartitionQueryParams corresponds to PartitionQueryRequest (https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L672), and SqlParams corresponds to ExecuteSqlRequest (https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L439). The former does not "include" the latter, so there may be options or fields in SqlParams that don't belong in PartitionQueryParams. Therefore, we should break this relationship now, while we can.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartitionQueryParams corresponds to PartitionQueryRequest
(https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L672),
and SqlParams corresponds to ExecuteSqlRequest
(https://github.com/googleapis/googleapis/blob/2c17ac33b226194041155bb5340c3f34733f1b3a/google/spanner/v1/spanner.proto#L439).
The former does not "include" the latter, so there may be options or
fields in SqlParams that don't belong in PartitionQueryParams.
Therefore, we should break this relationship now, while we can.
This change is