Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: moved INSTALL.md -> doc/packaging.md #1341

Merged
merged 3 commits into from
Mar 6, 2020

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Mar 6, 2020

This is the final step fixing #1309

INSTALL.md has been repurposed and renamed to doc/packaging.md. I also renamed the ci/test-readme directory to ci/test-markdown, which is more general.

You can preview the rendered markdown here: https://github.com/devjgm/google-cloud-cpp-spanner/blob/mv-install/doc/packaging.md


This change is Reviewable

@devjgm devjgm requested a review from coryan March 6, 2020 21:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2020
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1341 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   94.64%   94.69%   +0.04%     
==========================================
  Files         173      173              
  Lines       13644    13633      -11     
==========================================
- Hits        12914    12910       -4     
+ Misses        730      723       -7
Impacted Files Coverage Δ
...anner/integration_tests/client_integration_test.cc 98.5% <0%> (-0.01%) ⬇️
google/cloud/spanner/database_admin_connection.h
...oogle/cloud/spanner/internal/instance_admin_stub.h
...oogle/cloud/spanner/internal/database_admin_stub.h 100% <0%> (ø)
google/cloud/spanner/instance_admin_connection.h 100% <0%> (ø)
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.97% <0%> (ø) ⬆️
google/cloud/spanner/samples/samples.cc 89.62% <0%> (+0.28%) ⬆️
google/cloud/spanner/internal/log_wrapper.h 84.61% <0%> (+9.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13de1c1...136758e. Read the comment docs.

@devjgm devjgm merged commit b4eeea8 into googleapis:master Mar 6, 2020
@devjgm devjgm deleted the mv-install branch March 6, 2020 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants