feat: SqlStatement uses op<<(Value)
#1361
Conversation
googlebot
added
the
cla: yes
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
+ Coverage 94.53% 94.54% +<.01%
==========================================
Files 186 184 -2
Lines 15135 15152 +17
==========================================
+ Hits 14308 14325 +17
Misses 827 827
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Nobody should use PrintTo(Value, os). This PR documents that users
should not call PrintTo and that it will be removed in an upcoming
release.
This PR is actually removing PrintTo() was that intentional?
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @coryan)
There was a problem hiding this comment.
Oh I see, the symbol is gone, but the inline function is there.
Reviewed 1 of 1 files at r2.
Reviewable status:
devjgm
force-pushed
the
rm-printto
branch
2 times, most recently
from
e39c9e7
to
0fc7544
Compare
Nobody should use `PrintTo(Value, os)`. This PR documents that users should not call `PrintTo` and that it will be removed in an upcoming release. All streaming of `Value` objects should be done using `operator<<`. Note this PR changes the output format of `SqlStatement`, and it documents that the output format is for human consumption only and may change without notice in the future (same as is documented for Value).
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devbww)
…anner#1361) Nobody should use `PrintTo(Value, os)`. This PR documents that users should not call `PrintTo` and that it will be removed in an upcoming release. All streaming of `Value` objects should be done using `operator<<`. Note this PR changes the output format of `SqlStatement`, and it documents that the output format is for human consumption only and may change without notice in the future (same as is documented for Value).
Nobody should use
PrintTo(Value, os). This PR documents that usersshould not call
PrintToand that it will be removed in an upcomingrelease. All streaming of
Valueobjects should be done usingoperator<<.Note this PR changes the output format of
SqlStatement, and itdocuments that the output format is for human consumption only and may
change without notice in the future (same as is documented for Value).
This change is