Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

refactor: use g-c-cpp-common's async retry loop #1441

Merged
merged 3 commits into from
Mar 20, 2020
Merged

refactor: use g-c-cpp-common's async retry loop #1441

merged 3 commits into from
Mar 20, 2020

Conversation

coryan
Copy link
Member

@coryan coryan commented Mar 20, 2020

Part of the work for googleapis/google-cloud-cpp-common#243


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1441 into master will increase coverage by 0.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   93.55%   93.66%   +0.11%     
==========================================
  Files         193      187       -6     
  Lines       15852    15708     -144     
==========================================
- Hits        14830    14713     -117     
+ Misses       1022      995      -27
Impacted Files Coverage Δ
google/cloud/spanner/internal/session_pool_test.cc 99.57% <100%> (ø) ⬆️
google/cloud/spanner/internal/session_pool.cc 84.61% <33.33%> (ø) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 80.55% <0%> (-1.86%) ⬇️
google/cloud/spanner/client.cc 96.91% <0%> (-0.62%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-0.16%) ⬇️
google/cloud/spanner/internal/session.h 100% <0%> (ø) ⬆️
...cloud/spanner/internal/partial_result_set_resume.h 100% <0%> (ø) ⬆️
google/cloud/spanner/session_pool_options.h 100% <0%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.97% <0%> (ø) ⬆️
google/cloud/spanner/internal/spanner_stub.cc 66.66% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefe9f2...9691699. Read the comment docs.

@coryan coryan marked this pull request as ready for review March 20, 2020 14:51
@coryan coryan merged commit f819910 into googleapis:master Mar 20, 2020
@coryan coryan deleted the refactor-async-retry-from-common branch March 20, 2020 16:19
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants