Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

chore!: rename ExecuteSqlParams -> SqlParams #986

Merged
merged 2 commits into from
Oct 25, 2019
Merged

chore!: rename ExecuteSqlParams -> SqlParams #986

merged 2 commits into from
Oct 25, 2019

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Oct 25, 2019 •
edited by coryan

BREAKING CHANGE: This rename makes sense since we no longer have an
"ExecuteSql" function, and shorter name is clearer.

Fixes: #962

This change is Reviewable

@devjgm
chore!: rename ExecuteSqlParams -> SqlParams
1b12303 
BREAKING CHANGE: This rename makes sense since we no longer have an
"ExecuteSql" function, and shorter name is clearer.

Fixes: googleapis#962
@devjgm devjgm requested a review from coryan October 25, 2019 20:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
coryan
coryan suggested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR uses Sqlparams but the description says SqlParams, I think the description is the "Right Thing":tm: ?

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

devjgm
devjgm commented Oct 25, 2019
View reviewed changes
Copy link
Contributor Author

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Big oops. Good catch!

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @coryan)

coryan
coryan approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited

Codecov Report

Merging #986 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
- Coverage   94.18%   94.16%   -0.03%     
==========================================
  Files         159      159              
  Lines       10789    10782       -7     
==========================================
- Hits        10162    10153       -9     
- Misses        627      629       +2
Impacted Files Coverage Δ
google/cloud/spanner/internal/connection_impl.h 100% <ø> (ø) ⬆️
google/cloud/spanner/query_partition.h 100% <ø> (ø) ⬆️
google/cloud/spanner/samples/mock_execute_query.cc 100% <100%> (ø) ⬆️
google/cloud/spanner/query_partition.cc 96.15% <100%> (ø) ⬆️
google/cloud/spanner/internal/connection_impl.cc 96.34% <100%> (ø) ⬆️
google/cloud/spanner/client.cc 81.81% <100%> (-1.02%) ⬇️
google/cloud/spanner/query_partition_test.cc 100% <100%> (ø) ⬆️
google/cloud/spanner/connection.h 100% <100%> (ø) ⬆️
...ogle/cloud/spanner/mocks/mock_spanner_connection.h 60% <20%> (ø) ⬆️
google/cloud/spanner/internal/spanner_stub.cc 66.66% <0%> (-2.23%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4393f0b...b6fd9b1. Read the comment docs.

@devjgm devjgm merged commit 5250835 into googleapis:master Oct 25, 2019
@devjgm devjgm deleted the rename-sql-params branch October 25, 2019 22:50
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
@devjgm
chore!: rename ExecuteSqlParams -> SqlParams (googleapis/google-cloud…
e496b23 
…-cpp-spanner#986)

* chore!: rename ExecuteSqlParams -> SqlParams

BREAKING CHANGE: This rename makes sense since we no longer have an
"ExecuteSql" function, and shorter name is clearer.

Fixes: googleapis/google-cloud-cpp-spanner#962

* fixed bad typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename ExecuteSqlParams -> SqlParams
3 participants
@devjgm @coryan @googlebot