Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

bug: install the headers for mocking #997

Merged
merged 1 commit into from
Oct 29, 2019
Merged

bug: install the headers for mocking #997

merged 1 commit into from
Oct 29, 2019

Conversation

coryan
Copy link
Member

@coryan coryan commented Oct 28, 2019

Fixes #571


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #997 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #997      +/-   ##
=========================================
- Coverage   94.23%   94.2%   -0.03%     
=========================================
  Files         159     159              
  Lines       10836   10834       -2     
=========================================
- Hits        10211   10206       -5     
- Misses        625     628       +3
Impacted Files Coverage Δ
...loud/spanner/internal/partial_result_set_source.cc 92.95% <0%> (-1.41%) ⬇️
google/cloud/spanner/internal/spanner_stub.cc 67.77% <0%> (-1.12%) ⬇️
google/cloud/spanner/samples/samples.cc 89.5% <0%> (-0.39%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 85.55% <0%> (-0.16%) ⬇️
...anner/integration_tests/client_integration_test.cc 99.45% <0%> (ø) ⬆️
google/cloud/spanner/transaction.h 100% <0%> (ø) ⬆️
google/cloud/spanner/internal/polling_loop.h 94.59% <0%> (+2.7%) ⬆️
google/cloud/spanner/internal/retry_loop.h 100% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01e7fb...b2c9b8f. Read the comment docs.

Copy link
Contributor

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devbww, @devjgm, and @scotthart)

@coryan coryan merged commit 7261272 into googleapis:master Oct 29, 2019
@coryan coryan deleted the install-spanner-mocks branch October 29, 2019 12:22
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install the headers for the spanner mocks.
3 participants