Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GCS+gRPC plugin to v2 protos #6982

Closed
10 tasks done
coryan opened this issue Jul 13, 2021 · 4 comments · Fixed by #7272
Closed
10 tasks done

Move GCS+gRPC plugin to v2 protos #6982

coryan opened this issue Jul 13, 2021 · 4 comments · Fixed by #7272
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Member

coryan commented Jul 13, 2021

The v2 protos for GCS+gRPC were just published:

https://github.com/googleapis/googleapis/tree/master/google/storage/v2

We would like to move the GCS+gRPC plugin to use these protos. I anticipate at least the following steps:

  • Pick a new minimum version of Clang (DONE: 6.0) and create a build for it
  • Remove the clang-38 build and update documentation to say Clang-6.0 is the new minimum
  • Update the googleapis baseline.
  • Update all the builds to require Protobuf >= 3.15
  • Add the new protos to the storage_protos library.
  • Remove the functionality not available in v2/ protos.
  • Remove any tests or integration tests using functionality (e.g. metadata operations) that these protos do not implement.
  • Change the emulator to use the new protos.
  • Rewrite the StorageStub (and friends) and the internal::GrpcClient to use these new protos.
  • Figure out what to do with the QuotaUser field.
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. labels Jul 13, 2021
@coryan coryan added this to the Complete GCS+gRPC plugin milestone Jul 13, 2021
@coryan coryan self-assigned this Jul 15, 2021
@coryan
Copy link
Member Author

coryan commented Jul 15, 2021

I picked Clang-6.0 as the new minimum because it is the earliest default Clang in any of the distros we support. Ubuntu:16.04 ships with Clang-3.8, and Ubuntu:18.04 ships with Clang-6.0... So 6.0 it is.

@vnghia
Copy link
Contributor

vnghia commented Jul 17, 2021

Hi @coryan , please ping if there is anything I can help on this issue 😄

@coryan
Copy link
Member Author

coryan commented Jul 19, 2021

@vnvo2409 thanks for the offer. Please be patient with us, I just deleted a lot of the code you wrote, but we will add it back (with some -- hopefully minor -- changes).

@coryan
Copy link
Member Author

coryan commented Sep 3, 2021

Okay, I figured out the answer to quota user, we need to add this as as x-quota-user header in the grpc::ClientContext:

https://cloud.google.com/apis/docs/system-parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants