Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): generate authentication example #10138

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Oct 30, 2022

Create a minimal examples showing how to use service account
credentials for each *Client class.

Part of the work for #10114


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 703377e839546b6a5eb788a6d383b77b832d4a3a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 93.97% // Head: 93.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f3be4c5) compared to base (554a496).
Patch has no changes to coverable lines.

❗ Current head f3be4c5 differs from pull request most recent head 9d944b2. Consider uploading reports for the commit 9d944b2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #10138    +/-   ##
========================================
  Coverage   93.97%   93.97%            
========================================
  Files        1524     1523     -1     
  Lines      140332   140149   -183     
========================================
- Hits       131881   131712   -169     
+ Misses       8451     8437    -14     
Impacted Files Coverage Δ
...ud/internal/grpc_service_account_authentication.cc 72.22% <0.00%> (-11.12%) ⬇️
google/cloud/internal/unified_grpc_credentials.cc 79.48% <0.00%> (-10.26%) ⬇️
...le/cloud/pubsub/internal/publisher_stub_factory.cc 89.47% <0.00%> (-5.27%) ⬇️
google/cloud/pubsub/subscriber_connection.cc 76.81% <0.00%> (-2.90%) ⬇️
google/cloud/pubsub/schema_admin_connection.cc 90.47% <0.00%> (-1.91%) ⬇️
...ogle/cloud/pubsub/subscription_admin_connection.cc 83.00% <0.00%> (-1.00%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.81% <0.00%> (-0.55%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.34%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Create a minimal examples showing how to use service account
credentials for each `*Client` class.
@coryan coryan force-pushed the feat-generator-create-service-account-samples branch from 703377e to b12ad79 Compare October 30, 2022 18:20
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b12ad792cf428e55d505474d50e23e69b99c1fca

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan force-pushed the feat-generator-create-service-account-samples branch from b12ad79 to 9d944b2 Compare October 31, 2022 12:48
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 9d944b2d226502bbc2f22dca45142a274a3f0a2a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review October 31, 2022 13:30
@coryan coryan requested a review from a team as a code owner October 31, 2022 13:30
@coryan coryan merged commit 10a02af into googleapis:main Oct 31, 2022
@coryan coryan deleted the feat-generator-create-service-account-samples branch October 31, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants