feat: support a pre-release component of the version string #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `google::cloud::version_string()` to return, for example, "v2.5.0-rc" in pre-release builds. Update the release guide to describe the additional steps required.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.97% // Head: 93.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10181 +/- ##
==========================================
- Coverage 93.97% 93.97% -0.01%
==========================================
Files 1526 1526
Lines 140585 140606 +21
==========================================
+ Hits 132114 132132 +18
- Misses 8471 8474 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coryan
reviewed
Nov 7, 2022
dbolduc
reviewed
Nov 7, 2022
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
google::cloud::version_string()to return, for example, "v2.5.0-rc" in pre-release builds.Update the release guide to describe the additional steps required.
This change is