Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(common): add Doxygen group for common options #10192

Merged
merged 3 commits into from Nov 8, 2022

Conversation

coryan
Copy link
Member

@coryan coryan commented Nov 7, 2022

Fixes #10130


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d65775f0e1f0cb42d26c4512c2ef45601fa65500

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google/cloud/doc/options.dox Outdated Show resolved Hide resolved
google/cloud/doc/options.dox Outdated Show resolved Hide resolved
google/cloud/doc/options.dox Outdated Show resolved Hide resolved
@coryan coryan force-pushed the doc-common-add-options-group branch from d65775f to 305722f Compare November 7, 2022 22:23
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 305722f9b56d819cf0b69133e3d403a203a11d95

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google/cloud/doc/options.dox Outdated Show resolved Hide resolved
@coryan coryan marked this pull request as ready for review November 7, 2022 22:55
@coryan coryan requested a review from a team as a code owner November 7, 2022 22:55
@coryan coryan enabled auto-merge (squash) November 7, 2022 22:55
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 93.97% // Head: 93.96% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (400ec14) compared to base (71b11b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10192      +/-   ##
==========================================
- Coverage   93.97%   93.96%   -0.01%     
==========================================
  Files        1526     1526              
  Lines      140600   140600              
==========================================
- Hits       132130   132120      -10     
- Misses       8470     8480      +10     
Impacted Files Coverage Δ
google/cloud/options.h 97.82% <ø> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 68.85% <0.00%> (-6.56%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.84%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 99.62% <0.00%> (+0.18%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 400ec14dff5ae32eafc73dd5d8034ca630c25817

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit fe8f7eb into googleapis:main Nov 8, 2022
@coryan coryan deleted the doc-common-add-options-group branch November 8, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Doxygen group to aggregate all the *Option classes
3 participants