Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): generate AsyncWriteLogEntries() #10194

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Nov 7, 2022

This change is Reviewable

@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 93.97% // Head: 93.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (17eeadd) compared to base (b78b93f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10194      +/-   ##
==========================================
- Coverage   93.97%   93.97%   -0.01%     
==========================================
  Files        1528     1528              
  Lines      140657   140657              
==========================================
- Hits       132184   132181       -3     
- Misses       8473     8476       +3     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (-0.68%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.36% <0.00%> (+0.54%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 17eeadd9ef1a969f856f49c2836c11329fd80695

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review November 8, 2022 00:23
@coryan coryan requested a review from a team as a code owner November 8, 2022 00:23
@coryan coryan merged commit b2d57a2 into googleapis:main Nov 9, 2022
@coryan coryan deleted the feat-logging-generate-AsyncWriteLogEntries branch November 9, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants