Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(storage): create page for configuration options #10200

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

coryan
Copy link
Member

@coryan coryan commented Nov 8, 2022

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 93.98% // Head: 93.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (949e5e7) compared to base (31db707).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10200      +/-   ##
==========================================
- Coverage   93.98%   93.97%   -0.01%     
==========================================
  Files        1531     1531              
  Lines      141061   141061              
==========================================
- Hits       132570   132566       -4     
- Misses       8491     8495       +4     
Impacted Files Coverage Δ
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.36% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 949e5e7e2efdb3e72e2e1f49ca9aad0aa591571c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review November 8, 2022 01:43
@coryan coryan requested a review from a team as a code owner November 8, 2022 01:43
@coryan coryan merged commit 7b600b7 into googleapis:main Nov 8, 2022
@coryan coryan deleted the doc-storage-add-options-group branch November 8, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants