doc: use qualified client name in samples #10241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.84% // Head: 93.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10241 +/- ##
==========================================
- Coverage 93.84% 93.84% -0.01%
==========================================
Files 1541 1541
Lines 142163 142163
==========================================
- Hits 133419 133417 -2
- Misses 8744 8746 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coryan
approved these changes
Nov 14, 2022
| @@ -48,7 +48,7 @@ Status SampleGenerator::GenerateHeader() { | |||
| HeaderSystemIncludes({"iostream", "fstream", "string", "vector"}); | |||
|
|
|||
| HeaderPrint(R"""( | |||
| // main-dox-marker: $client_class_name$ | |||
| // main-dox-marker: $product_namespace$::$client_class_name$ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #10170
We will need this for speech, which has conflicting client names.
This change is