Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(bigtable): build admin samples with cmake #10246

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Nov 14, 2022

These samples were never built with cmake. We run them with bazel in the integration-production build.

We still do not run them, but at least they are built in clang-tidy.


This change is Reviewable

@product-auto-label product-auto-label bot added api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples. labels Nov 14, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f91979958a4efd11a8ceaee40aaa41fa144cc3e3

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review November 14, 2022 22:27
@dbolduc dbolduc requested a review from a team as a code owner November 14, 2022 22:27
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 93.84% // Head: 93.84% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f919799) compared to base (ba4669e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10246      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files        1541     1541              
  Lines      142163   142163              
==========================================
- Hits       133418   133417       -1     
- Misses       8745     8746       +1     
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 97.81% <0.00%> (-0.55%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.34%) ⬇️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc merged commit 793faa1 into googleapis:main Nov 15, 2022
@dbolduc dbolduc deleted the bigtable-admin-samples-cmake branch November 15, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants