doc(spanner): deprecate old MakeConnection() overloads #10284
Conversation
Raise the disfavor for `ConnectionOptions` and `SessionPoolOptions` arguments to `spanner::MakeConnection()` from @note to @deprecated. Also removed some stale inclusions of `connection_options.h` and `session_pool_options.h`.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.84% // Head: 93.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10284 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 1575 1575
Lines 144311 144311
=======================================
+ Hits 135424 135427 +3
+ Misses 8887 8884 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -961,8 +961,8 @@ std::shared_ptr<spanner::Connection> MakeConnection(spanner::Database const& db, | |||
| * The returned connection object should not be used directly, rather it should | |||
| * be given to a `Client` instance, and methods should be invoked on `Client`. | |||
| * | |||
| * @note Prefer using the `MakeConnection()` overload that accepts | |||
| * `google::cloud::Options`. | |||
| * @deprecated Please use the `MakeConnection()` overload that accepts | |||
There was a problem hiding this comment.
Should we add the [[deprecated]] attribute too?
There was a problem hiding this comment.
I planned to leave that until the old DatabaseAdminClient goes away. But, maybe it would be better to try to kill them both with the same stone. I'll think on it.
Raise the disfavor for
ConnectionOptionsandSessionPoolOptionsarguments tospanner::MakeConnection()from @note to @deprecated.Also removed some stale inclusions of
connection_options.handsession_pool_options.h.This change is