feat(pubsub): add option to override subscription #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For historical reasons, a `pubsub::SubscriberConnection` has a subscription assigned to it. With this change that subscription becomes the default, and one can provide an override via the `Options` argument.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.84% // Head: 93.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10327 +/- ##
========================================
Coverage 93.84% 93.85%
========================================
Files 1596 1596
Lines 145150 145312 +162
========================================
+ Hits 136220 136380 +160
- Misses 8930 8932 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
devbww
approved these changes
Nov 29, 2022
google/cloud/pubsub/options.h
Outdated
| * Override the default subscription for a request. | ||
| * | ||
| * Some applications need to receive messages from multiple subscriptions. In | ||
| * these case they can use this option to override the default |
There was a problem hiding this comment.
s/these case/these cases/ or /this case/
google/cloud/pubsub/options.h
Outdated
| * Override the default subscription for a request. | ||
| * | ||
| * Some applications need to receive messages from multiple subscriptions. In | ||
| * these case they can use this option to override the default |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, a
pubsub::SubscriberConnectionhas a subscription assigned to it. With this change that subscription becomes the default, and one can provide an override via theOptionsargument.Motivated by #10320 and #9171
This change is