Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(storage): document all oauth2 names as deprecated #10352

Conversation

coryan
Copy link
Member

@coryan coryan commented Dec 2, 2022

Update the Doxygen comments to mark every type, function, and even the complete namespace as deprecated. In the next major release we will actually add the [[deprecated]] attribute, and (maybe) remove them in the major release following it.

Motivated by #10353


This change is Reviewable

Update the Doxygen comments to mark every type, function, and even the
complete namespace as deprecated.  In the next major release we will
actually add the `[[deprecated]]` attribute, and (maybe) remove them
in the major release following it.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 2, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d783689feb496f18ddf79e18476aa83e94a15d61

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 93.87% // Head: 93.86% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d783689) compared to base (654ee7e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10352      +/-   ##
==========================================
- Coverage   93.87%   93.86%   -0.01%     
==========================================
  Files        1600     1600              
  Lines      145763   145763              
==========================================
- Hits       136829   136824       -5     
- Misses       8934     8939       +5     
Impacted Files Coverage Δ
...oogle/cloud/storage/oauth2/anonymous_credentials.h 100.00% <ø> (ø)
...cloud/storage/oauth2/authorized_user_credentials.h 93.93% <ø> (ø)
.../cloud/storage/oauth2/compute_engine_credentials.h 96.66% <ø> (ø)
google/cloud/storage/oauth2/credential_constants.h 33.33% <ø> (ø)
google/cloud/storage/oauth2/credentials.h 66.66% <ø> (ø)
...ud/storage/oauth2/refreshing_credentials_wrapper.h 100.00% <ø> (ø)
...cloud/storage/oauth2/service_account_credentials.h 86.88% <ø> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 2, 2022 17:44
@coryan coryan requested a review from a team as a code owner December 2, 2022 17:44
@coryan coryan merged commit fda5300 into googleapis:main Dec 2, 2022
@coryan coryan deleted the doc-storage-document-credentials-as-deprecated branch December 2, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants