feat: consume less entropy for PRNG #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initialized our PRNG with a lot of entropy. This was overkill, and the entropy sources are not always an infinite resource.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11102 +/- ##
==========================================
- Coverage 93.78% 93.78% -0.01%
==========================================
Files 1737 1737
Lines 156898 156897 -1
==========================================
- Hits 147152 147145 -7
- Misses 9746 9752 +6
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Mar 24, 2023
google/cloud/internal/random.h
Outdated
| /// Create a new PRNG. | ||
| inline DefaultPRNG MakeDefaultPRNG() { | ||
| // Fetch a few (typically 64) bits of entropy to initialize the PRNG. We used | ||
| // to fetch a lot more entropy, but that is overkill for our purposes. |
There was a problem hiding this comment.
I'd reword to avoid talking about what we used to do, and rather speak to what we now do.
Perhaps just "Fetch a few bits ..., which is sufficient for our purposes"?
|
/gcbrun |
coryan
added
the
kokoro:force-run
google-cloud-cpp-bot
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initialized our PRNG with a lot of entropy. This was overkill, and the entropy sources are not always an infinite resource.
This change is