Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): cache all credential types #11447

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Apr 29, 2023

Applications may call AuthorizedHeader() and that can generate calls to the GCE metadata service or Google's Security Token Service.

Fixes #11442


This change is Reviewable

Applications may call `AuthorizedHeader()` and that can generate calls
to the GCE metadata service or Google's Security Token Service.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 98.03% and no project coverage change.

Comparison is base (90a6882) 93.78% compared to head (f95e1b1) 93.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11447   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files        1805     1805           
  Lines      162337   162431   +94     
=======================================
+ Hits       152244   152341   +97     
+ Misses      10093    10090    -3     
Impacted Files Coverage Δ
...cloud/storage/oauth2/authorized_user_credentials.h 92.85% <66.66%> (+0.54%) ⬆️
.../cloud/storage/oauth2/compute_engine_credentials.h 96.66% <80.00%> (+0.11%) ⬆️
...loud/storage/oauth2/authorized_user_credentials.cc 96.00% <100.00%> (+0.44%) ⬆️
...storage/oauth2/authorized_user_credentials_test.cc 98.00% <100.00%> (+0.36%) ⬆️
...cloud/storage/oauth2/compute_engine_credentials.cc 100.00% <100.00%> (ø)
.../storage/oauth2/compute_engine_credentials_test.cc 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review April 30, 2023 00:23
@coryan coryan requested a review from a team as a code owner April 30, 2023 00:23
@coryan coryan merged commit 69ea716 into googleapis:main May 1, 2023
59 checks passed
@coryan coryan deleted the fix-storage-cache-all-legacy-credentials branch May 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All storage::oauth2::*Credentials need caching
2 participants