Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(pubsub): add get/delete/rollback schema samples #11848

Merged
merged 4 commits into from Jun 12, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Jun 9, 2023

Issue 11720


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner June 9, 2023 19:46
@snippet-bot
Copy link

snippet-bot bot commented Jun 9, 2023

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jun 9, 2023
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alevenberg)


google/cloud/pubsub/samples/samples.cc line 2067 at r1 (raw file):

  GetSchema(schema_admin, {project_id, avro_schema_id});

  // For testing RollbackSchema, create 2 new schema revisions and rollback to

nit: s/For testing/To test/ ? 🤷 what do I know.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (f4d98f6) 93.79% compared to head (a4371dd) 93.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11848      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.01%     
==========================================
  Files        1838     1838              
  Lines      166384   166441      +57     
==========================================
+ Hits       156067   156152      +85     
+ Misses      10317    10289      -28     
Impacted Files Coverage Δ
...ogle/cloud/pubsub/samples/pubsub_samples_common.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/samples/samples.cc 87.56% <100.00%> (+0.36%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alevenberg alevenberg merged commit 94dc583 into googleapis:main Jun 12, 2023
58 of 59 checks passed
alevenberg added a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants