Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(spanner): document RetryPolicy interface #12037

Merged
merged 2 commits into from Jul 6, 2023
Merged

docs(spanner): document RetryPolicy interface #12037

merged 2 commits into from Jul 6, 2023

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 6, 2023 •
edited

Part of the work for #9434

This change is Reviewable

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jul 6, 2023
@coryan coryan changed the title feat(spanner): document RetryPolicy interface docs(spanner): document RetryPolicy interface Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited

Codecov Report

Patch coverage: 89.13% and no project coverage change.

Comparison is base (6bc7722) 93.70% compared to head (4c504cc) 93.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12037   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files        2013     2013           
  Lines      174916   174962   +46     
=======================================
+ Hits       163903   163950   +47     
+ Misses      11013    11012    -1
Impacted Files Coverage Δ
google/cloud/spanner/retry_policy.h 91.66% <89.13%> (-8.34%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review July 6, 2023 15:48
@coryan coryan requested a review from a team as a code owner July 6, 2023 15:48
devbww
devbww approved these changes Jul 6, 2023
View reviewed changes
google/cloud/spanner/retry_policy.h Outdated Show resolved Hide resolved
google/cloud/spanner/retry_policy.h Outdated Show resolved Hide resolved
@coryan coryan enabled auto-merge (squash) July 6, 2023 17:53
@coryan coryan merged commit 4550d52 into googleapis:main Jul 6, 2023
57 checks passed
@coryan coryan deleted the docs-spanner-document-retry-policies branch July 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coryan @devbww