Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigtable): document DataRetryPolicy #12040

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 6, 2023

Changed the comments and class order to match the generated code and the code in other hand-crafted libraries.

Fixes #9434


This change is Reviewable

Changed the comments and class order to match the generated code and the
code in other hand-crafted libraries.
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 6, 2023
@coryan coryan marked this pull request as ready for review July 6, 2023 18:54
@coryan coryan requested a review from a team as a code owner July 6, 2023 18:54
@coryan coryan enabled auto-merge (squash) July 6, 2023 18:54
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4550d52) 93.70% compared to head (f5c56bd) 93.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12040   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files        2013     2013           
  Lines      175000   175000           
=======================================
+ Hits       163979   163983    +4     
+ Misses      11021    11017    -4     
Impacted Files Coverage Δ
google/cloud/bigtable/retry_policy.h 88.88% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2023
@coryan coryan merged commit 9242a43 into googleapis:main Jul 6, 2023
57 checks passed
@coryan coryan deleted the docs-bigtable-document-retry-policies branch July 6, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should release our policy types
3 participants