Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): add a subscriber quickstart #12053

Merged
merged 10 commits into from Jul 10, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Jul 10, 2023

Create a subscriber executable for the Pub/Sub quickstart


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner July 10, 2023 14:37
@snippet-bot
Copy link

snippet-bot bot commented Jul 10, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ce34eb) 93.68% compared to head (9c6e9b2) 93.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12053   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files        2014     2014           
  Lines      175262   175262           
=======================================
+ Hits       164190   164192    +2     
+ Misses      11072    11070    -2     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

google/cloud/pubsub/samples/samples.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/README.md Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/README.md Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/BUILD.bazel Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/quickstart.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/quickstart.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/subscriber_quickstart.cc Outdated Show resolved Hide resolved
google/cloud/pubsub/quickstart/subscriber_quickstart.cc Outdated Show resolved Hide resolved
Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to rebase if you want the new build to pass.

google/cloud/pubsub/quickstart/CMakeLists.txt Outdated Show resolved Hide resolved
@alevenberg alevenberg merged commit ee9a805 into googleapis:main Jul 10, 2023
58 checks passed
@alevenberg alevenberg deleted the alevenb/pubsub branch July 10, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants