Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC warnings. #1207

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Fix MSVC warnings. #1207

merged 1 commit into from
Oct 3, 2018

Conversation

coryan
Copy link
Member

@coryan coryan commented Oct 2, 2018 •
edited
Loading

MSVC defines min() and max() as macros, which creates trouble when
using min() and/or max() in some namespace. Workaround the problem
by wrapping the names in parenthesis (yuck).

This change is Reviewable

@coryan
Fix MSVC warnings.
03e3901 
MSVC defines `min()` and `max()` as macros, which creates trouble when
using `min()` and/or `max()` in some namespace. Workaround the problem
by wrapping the names in parenthesis (yuck).
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. labels Oct 2, 2018
@coryan coryan requested a review from houglum October 2, 2018 21:22
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. labels Oct 2, 2018
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #1207 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1207   +/-   ##
======================================
  Coverage    92.2%   92.2%           
======================================
  Files         223     223           
  Lines       12298   12298           
======================================
  Hits        11339   11339           
  Misses        959     959
Impacted Files Coverage Δ
google/cloud/storage/well_known_headers.h 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5b9f2...03e3901. Read the comment docs.

houglum
houglum approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@houglum houglum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coryan coryan merged commit bf5a4f4 into googleapis:master Oct 3, 2018
@coryan coryan deleted the fix-msvc-minmax-warnings branch October 3, 2018 03:02
@dbolduc dbolduc mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houglum houglum houglum approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coryan @houglum @googlebot