Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): add missing library on Windows #12103

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 16, 2023

This change is Reviewable

@coryan coryan temporarily deployed to internal July 16, 2023 15:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e34c8da) 93.68% compared to head (d4e2581) 93.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12103      +/-   ##
==========================================
- Coverage   93.68%   93.68%   -0.01%     
==========================================
  Files        2012     2012              
  Lines      175732   175732              
==========================================
- Hits       164635   164633       -2     
- Misses      11097    11099       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review July 16, 2023 15:49
@coryan coryan requested a review from a team as a code owner July 16, 2023 15:49
@coryan coryan merged commit 92526f5 into googleapis:main Jul 16, 2023
59 checks passed
@coryan coryan deleted the fix-common-add-missing-Windows-library branch July 16, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants