Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): trace auth when default credentials are assumed #12672

Merged
merged 1 commit into from Sep 19, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 19, 2023

Fixes #12332

If tracing is enabled in the connection, and no credentials are supplied via Options, assume that the customer wants to trace the auth components.

For example, in our OTel tracing quickstart...

Before:
image

After:
image


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal September 19, 2023 03:07 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 19, 2023
@dbolduc dbolduc marked this pull request as ready for review September 19, 2023 03:28
@dbolduc dbolduc requested a review from a team as a code owner September 19, 2023 03:28
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (31722a1) 93.57% compared to head (6ce480e) 93.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12672   +/-   ##
=======================================
  Coverage   93.57%   93.58%           
=======================================
  Files        2061     2061           
  Lines      182840   182841    +1     
=======================================
+ Hits       171100   171104    +4     
+ Misses      11740    11737    -3     
Files Changed Coverage Δ
google/cloud/storage/client_options.cc 86.66% <100.00%> (+0.07%) ⬆️
google/cloud/storage/internal/grpc/stub.cc 98.93% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 476d6ef into googleapis:main Sep 19, 2023
54 checks passed
@dbolduc dbolduc deleted the fix-storage-tracing-auth branch September 19, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing for REST / oauth2 components
2 participants