fix: export headers with top-level Bazel targets #12762
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12762 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2078 2078
Lines 182481 182481
=======================================
Hits 170786 170786
Misses 11695 11695
☔ View full report in Codecov by Sentry. |
| @@ -159,13 +189,15 @@ cc_library( | |||
| cc_library( | |||
| name = "mocks", | |||
| testonly = True, | |||
| hdrs = ["//google/cloud:mocks"], | |||
There was a problem hiding this comment.
Both are consistent. I am fine with your choice.
There was a problem hiding this comment.
I just went with the most commonly used names. I figured we can change them later if we wanted to.
| @@ -67,6 +67,12 @@ config_setting( | |||
| }, | |||
| ) | |||
|
|
|||
| filegroup( | |||
| name = "common_hdrs", | |||
| srcs = [h for h in google_cloud_cpp_common_hdrs if not h.startswith("internal/")], | |||
There was a problem hiding this comment.
Observation: we are doing this internal filtering on handwritten libraries. Our fully generated libraries also have internal headers which are picked up by globs.
Do we care to filter both?
There was a problem hiding this comment.
Yes. That is one of the reasons why this is "part of" and not "fixes" for that bug.
There was a problem hiding this comment.
I included the fixes in this PR. PTAL
| @@ -31,11 +31,13 @@ filegroup( | |||
| filegroup( | |||
| name = "hdrs", | |||
| srcs = glob([d + "*.h" for d in src_dirs]), | |||
| visibility = ["//:__pkg__"], | |||
| ) | |||
There was a problem hiding this comment.
e.g.
filegroup(
name = "public_hdrs",
srcs = glob([d + "*.h" for d in service_dirs]),
visibility = ["//:__pkg__"],
)
(Note the service_dirs instead of src_dirs)
There was a problem hiding this comment.
Good idea, that may be handy in a follow up PR.
Part of the work for #12760
This change is