feat(common): new *Option to configure HTTP proxy
#12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12766 +/- ##
========================================
Coverage 93.59% 93.59%
========================================
Files 2081 2082 +1
Lines 182874 182987 +113
========================================
+ Hits 171162 171272 +110
- Misses 11712 11715 +3
☔ View full report in Codecov by Sentry. |
devbww
reviewed
Sep 29, 2023
devbww
approved these changes
Sep 29, 2023
dbolduc
reviewed
Sep 29, 2023
google/cloud/common_options.h
Outdated
| * | ||
| * The full URI is constructed as: | ||
| * | ||
| * {scheme}://{username}:{password}@{host}:{port} |
Applications can use this option to configure the HTTP proxy settings. Some applications need to set the username and password and this cannot be done through environment variables (for `libcurl`).
coryan
force-pushed
the
feat-support-proxy-options
branch
from
689fdbd
to
769cf7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications can use this option to configure the HTTP proxy settings. Some applications need to set the username and password and this cannot be done through environment variables (for
libcurl).Fixes #12764
This change is