fix(compute): usable in external Bazel projects #12864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: compute
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12864 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2075 2075
Lines 180728 180728
=======================================
+ Hits 169068 169070 +2
+ Misses 11660 11658 -2 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
fix-compute-usable-from-external-projects
branch
from
881eaeb
to
8ae798a
Compare
coryan
force-pushed
the
fix-compute-usable-from-external-projects
branch
from
8ae97e1
to
c19c79b
Compare
The library was not usable from external Bazel projects. Including proto files via angle brackets requires `includes` attributes in the right `cc_library()` rules. Bazel does not allow `includes` pointing to the top of the project, so we need at least the protos to live outside the `google/cloud/compute` subtree. Using `protos/` seems reasonable, and can grow as needed.
coryan
force-pushed
the
fix-compute-usable-from-external-projects
branch
from
c19c79b
to
c8b639e
Compare
scotthart
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Reviewed 241 of 241 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was not usable from external Bazel projects. Including
proto files via angle brackets requires
includesattributes in theright
cc_library()rules. Bazel does not allowincludespointing tothe top of the project, so we need at least the protos to live outside
the
google/cloud/computesubtree. Usingprotos/seems reasonable,and can grow as needed.
Fixes #12854
This change is