fix(oauth2): only enable via GOOGLE_CLOUD_CPP_ENABLE #12911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12911 +/- ##
==========================================
- Coverage 93.61% 93.61% -0.01%
==========================================
Files 2067 2067
Lines 180057 180057
==========================================
- Hits 168559 168558 -1
- Misses 11498 11499 +1 ☔ View full report in Codecov by Sentry. |
Ah. Ok, I see the motivation now. I am OK calling this a bug. |
dbolduc
approved these changes
Oct 17, 2023
Enabling `oauth2` if `GOOGLE_CLOUD_CPPP_ENABLE_REST` is set is a bug: it introduces a cycle in the dependencies of the library, and makes it impossible to compile `oauth2`, `storage`, and `compute` in different shards.
coryan
force-pushed
the
fix-oauth2-do-not-enable-if-rest-is
branch
from
9dc2643
to
d1fee32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
oauth2ifGOOGLE_CLOUD_CPPP_ENABLE_RESTis set is a bug: it introduces a cycle in the dependencies of the library, and makes it impossible to compileoauth2,storage, andcomputein different shards.This change is