Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): end async client spans properly #12919

Merged
merged 3 commits into from Oct 18, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 18, 2023

Part of the work for #12880

Keep track of the current context in our generated async APIs (and for APIs that return a StreamRange which also needs to restore the original call context before sending RPCs).

This still leaves handwritten traces for async APIs (bigtable, storage, pubsub) looking wonky. They get fixed next.

Have stricter unit tests that verify the new behavior.


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal October 18, 2023 18:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d50ebb) 93.61% compared to head (8fdf590) 93.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12919   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files        2067     2067           
  Lines      180104   180116   +12     
=======================================
+ Hits       168601   168624   +23     
+ Misses      11503    11492   -11     
Files Coverage Δ
...internal/golden_kitchen_sink_tracing_connection.cc 100.00% <100.00%> (ø)
...en/v1/internal/golden_kitchen_sink_tracing_stub.cc 93.51% <100.00%> (ø)
.../internal/golden_thing_admin_tracing_connection.cc 100.00% <100.00%> (ø)
...sts/golden_kitchen_sink_tracing_connection_test.cc 100.00% <100.00%> (ø)
...sts/tests/golden_kitchen_sink_tracing_stub_test.cc 99.57% <100.00%> (+<0.01%) ⬆️
...ests/golden_thing_admin_tracing_connection_test.cc 100.00% <100.00%> (ø)
...ests/tests/golden_thing_admin_tracing_stub_test.cc 100.00% <100.00%> (ø)
generator/internal/tracing_connection_generator.cc 43.90% <ø> (ø)
generator/internal/tracing_stub_generator.cc 62.29% <ø> (ø)
...den/v1/internal/golden_thing_admin_tracing_stub.cc 95.59% <88.88%> (+0.35%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review October 18, 2023 20:29
@dbolduc dbolduc requested a review from a team as a code owner October 18, 2023 20:29
@dbolduc dbolduc merged commit 2c26eb9 into googleapis:main Oct 18, 2023
54 checks passed
@dbolduc dbolduc deleted the otel-async-context-gapics branch October 18, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants