Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): async context propagation for tracing #13156

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Nov 17, 2023

Fixes #12880, a similar PR to #12921, which was for updating storage. This one is for bigtable.

Generally, we need to replace any opentelemetry::trace::Scope with g::c::i::OTelScope. And if we are not using EndSpan(..., future<T>), be sure to manually DetachOTelContext(...) when the operation is over.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (37619f6) 92.99% compared to head (0a288f4) 92.99%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../bigtable/internal/data_tracing_connection_test.cc 98.36% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13156   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files        2137     2137           
  Lines      185828   185855   +27     
=======================================
+ Hits       172815   172842   +27     
  Misses      13013    13013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review November 17, 2023 06:54
@dbolduc dbolduc requested a review from a team as a code owner November 17, 2023 06:54
@dbolduc dbolduc merged commit ffe3d20 into googleapis:main Nov 17, 2023
59 checks passed
@dbolduc dbolduc deleted the otel-async-context-bigtable branch November 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix async context propagation
2 participants