fix: respect logging format env var in compute, sql
#13368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13368 +/- ##
==========================================
- Coverage 93.07% 93.07% -0.01%
==========================================
Files 2148 2148
Lines 187465 187473 +8
==========================================
+ Hits 174488 174494 +6
- Misses 12977 12979 +2 ☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #13361
We are copying the gRPC implementation. Of course I am just noticing that in the implementation, setting the
*TracingOptionsOptionwill override theGOOGLE_CLOUD_CPP_TRACING_OPTIONS, which is at odds with our ADR.This change is